Skip to content

Fix Carthage build for Xcode 12#1317

Merged
SergioEstevao merged 4 commits into
developfrom
issue/1313_carthage_build
Jan 4, 2021
Merged

Fix Carthage build for Xcode 12#1317
SergioEstevao merged 4 commits into
developfrom
issue/1313_carthage_build

Conversation

@SergioEstevao

@SergioEstevao SergioEstevao commented Dec 30, 2020

Copy link
Copy Markdown
Contributor

Fixes #1313

Adds a Carthage script and configures a setting in the project to allow to build Gridicons on the Example project.

To test:

  • Make sure you are able to build and run the Example project following the updated instructions in the readme.

@SergioEstevao SergioEstevao added this to the Next Stable milestone Dec 30, 2020
guarani
guarani approved these changes Dec 30, 2020
View reviewed changes

@guarani guarani left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @SergioEstevao!

Maybe we could link back to the original solution here: Carthage/Carthage#3019 (comment), wdyt?

@SergioEstevao

SergioEstevao commented Jan 1, 2021

Copy link
Copy Markdown
Contributor Author

LGTM! Thanks @SergioEstevao!

Maybe we could link back to the original solution here: Carthage/Carthage#3019 (comment), wdyt?

Do you think we should add the link in the Readme file of this repo, in the part I suggest the alternative use for Xcode 12?

@guarani

guarani commented Jan 4, 2021

Copy link
Copy Markdown

Do you think we should add the link in the Readme file of this repo, in the part I suggest the alternative use for Xcode 12?

@SergioEstevao what do you think if we add a comment in Example/carthage.sh that links back to Carthage/Carthage#3019 (comment)?

@SergioEstevao
SergioEstevao merged commit bec35ea into develop Jan 4, 2021
@SergioEstevao
SergioEstevao deleted the issue/1313_carthage_build branch January 4, 2021 18:13
@dcalhoun

dcalhoun commented Feb 22, 2021

Copy link
Copy Markdown
Member

Moving this PR to the existing 1.19.4 milestone. There appears to have been some confusion and two milestones were created — 1.19.4 and a "Next Stable." The latter will become the milestone for a future release.

Let me know if I am mistaken and we should revert the milestone change. Thanks!

@dcalhoun dcalhoun modified the milestones: Next Stable, 1.19.4 Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@guarani guarani guarani approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

[Type] Tech Debt / Tech Task

Projects

None yet

Milestone

1.19.4

Development

Successfully merging this pull request may close these issues.

the example can not run on xcode12 iPhone simulator12pro max14.2

3 participants

@SergioEstevao @guarani @dcalhoun